noth/surrealpatch
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
surrealpatch/lib/src/sql/value/clear.rs

44 lines
930 B
Rust
Raw Normal View History

Don’t clone variables when processing sub-contexts Closes SUR-53 When creating a new context for subqueries or statement clauses, we used to have to clone any variables/values, and freeze the context, so that it could be used across threads and async boundaries. Now with the new executor pattern for parallel queries, we can pass references instead, improving performance by removing unnecessary cloning of values.
2022-05-14 12:35:08 +00:00
use crate::ctx::Context;
Return a Result from async methods on Value Instead of silently failing, the async methods on a Value for getting, setting, and updating the value, now return a Result. This means we can chain the awaited result using the ? operator.
2022-01-20 23:00:57 +00:00
use crate::dbs::Options;
Only pass transaction when processing queries Instead of passing the executor instance, we only need to pass the current transaction which is to be used for processing and running any queries.
2022-02-15 01:00:30 +00:00
use crate::dbs::Transaction;
Return a Result from async methods on Value Instead of silently failing, the async methods on a Value for getting, setting, and updating the value, now return a Result. This means we can chain the awaited result using the ? operator.
2022-01-20 23:00:57 +00:00
use crate::err::Error;
use crate::sql::value::Value;
impl Value {
pub async fn clear(
&mut self,
Don’t clone variables when processing sub-contexts Closes SUR-53 When creating a new context for subqueries or statement clauses, we used to have to clone any variables/values, and freeze the context, so that it could be used across threads and async boundaries. Now with the new executor pattern for parallel queries, we can pass references instead, improving performance by removing unnecessary cloning of values.
2022-05-14 12:35:08 +00:00
_ctx: &Context<'_>,
Don't store selected NS and DB on executor
2022-02-06 21:06:52 +00:00
_opt: &Options,
Switch to asynchronous owned mutex locks in underlying kv storage
2022-02-15 03:33:16 +00:00
_txn: &Transaction,
Return a Result from async methods on Value Instead of silently failing, the async methods on a Value for getting, setting, and updating the value, now return a Result. This means we can chain the awaited result using the ? operator.
2022-01-20 23:00:57 +00:00
) -> Result<(), Error> {
Use Value::base() as the default record value
2022-02-09 08:23:14 +00:00
*self = Value::base();
Return a Result from async methods on Value Instead of silently failing, the async methods on a Value for getting, setting, and updating the value, now return a Result. This means we can chain the awaited result using the ? operator.
2022-01-20 23:00:57 +00:00
Ok(())
}
}
#[cfg(test)]
mod tests {
use super::*;
use crate::dbs::test::mock;
use crate::sql::test::Parse;
#[tokio::test]
async fn clear_none() {
Only pass transaction when processing queries Instead of passing the executor instance, we only need to pass the current transaction which is to be used for processing and running any queries.
2022-02-15 01:00:30 +00:00
let (ctx, opt, txn) = mock().await;
Return a Result from async methods on Value Instead of silently failing, the async methods on a Value for getting, setting, and updating the value, now return a Result. This means we can chain the awaited result using the ? operator.
2022-01-20 23:00:57 +00:00
let mut val = Value::parse("{ test: { other: null, something: 123 } }");
let res = Value::parse("{}");
Only pass transaction when processing queries Instead of passing the executor instance, we only need to pass the current transaction which is to be used for processing and running any queries.
2022-02-15 01:00:30 +00:00
val.clear(&ctx, &opt, &txn).await.unwrap();
Return a Result from async methods on Value Instead of silently failing, the async methods on a Value for getting, setting, and updating the value, now return a Result. This means we can chain the awaited result using the ? operator.
2022-01-20 23:00:57 +00:00
assert_eq!(res, val);
}
#[tokio::test]
async fn clear_path() {
Only pass transaction when processing queries Instead of passing the executor instance, we only need to pass the current transaction which is to be used for processing and running any queries.
2022-02-15 01:00:30 +00:00
let (ctx, opt, txn) = mock().await;
Return a Result from async methods on Value Instead of silently failing, the async methods on a Value for getting, setting, and updating the value, now return a Result. This means we can chain the awaited result using the ? operator.
2022-01-20 23:00:57 +00:00
let mut val = Value::parse("{ test: { other: null, something: 123 } }");
let res = Value::parse("{}");
Only pass transaction when processing queries Instead of passing the executor instance, we only need to pass the current transaction which is to be used for processing and running any queries.
2022-02-15 01:00:30 +00:00
val.clear(&ctx, &opt, &txn).await.unwrap();
Return a Result from async methods on Value Instead of silently failing, the async methods on a Value for getting, setting, and updating the value, now return a Result. This means we can chain the awaited result using the ? operator.
2022-01-20 23:00:57 +00:00
assert_eq!(res, val);
}
}
Reference in a new issue Copy permalink