noth/surrealpatch
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Remove TCP deadline timeouts completely

Browse source 
Deadline timeouts are not useful, as they do not give any meaningful http error responses to the end user. Instead we now make use of contexts throught the system to detect query timeouts, and send error messages accordingly.
This commit is contained in:
Tobie Morgan Hitchcock 2017-11-16 20:48:08 +00:00
parent 9fb7eec04b
commit 8f06b958ff
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
web/web.go
View file

@ -32,9 +32,7 @@ func Setup(opts *cnf.Options) (err error) {
routes(s) routes(s)
s.SetWait("15s") s.SetWait("15s")
s.SetName("web") s.SetName("web")
s.SetReadTimeout("5s")
s.SetIdleTimeout("60s") s.SetIdleTimeout("60s")
s.SetWriteTimeout("30s")
s.SetHTTPErrorHandler(errors) s.SetHTTPErrorHandler(errors)
s.Logger().SetLogger(log.Instance()) s.Logger().SetLogger(log.Instance())