Default to true for WHEN on DEFINE EVENT statement (#4662)

core/src/syn/parser/stmt/define.rs

@@ -3,6 +3,7 @@ use reblessive::Stk;
 use crate::cnf::EXPERIMENTAL_BEARER_ACCESS;
 use crate::sql::access_type::JwtAccessVerify;
 use crate::sql::index::HnswParams;
+use crate::sql::Value;
 use crate::{
 	sql::{
 		access_type,
@@ -738,6 +739,7 @@ impl Parser<'_> {
 		let mut res = DefineEventStatement {
 			name,
 			what,
+			when: Value::Bool(true),
 			if_not_exists,
 			overwrite,
 			..Default::default()

sdk/tests/define.rs

@@ -344,6 +344,32 @@ async fn define_statement_event() -> Result<(), Error> {
 	Ok(())
 }
 
+// Confirms that a DEFINE EVENT with no WHERE clause will produce WHEN true
+#[tokio::test]
+async fn define_statement_event_no_when_clause() -> Result<(), Error> {
+	let sql = "
+		DEFINE EVENT some_event ON TABLE user THEN {};
+		INFO FOR TABLE user;
+	";
+	let mut t = Test::new(sql).await?;
+	//
+	t.skip_ok(1)?;
+	let val = Value::parse(
+		"{
+	events: {
+		some_event: 'DEFINE EVENT some_event ON user WHEN true THEN {  }'
+	},
+	fields: {},
+	indexes: {},
+	lives: {},
+	tables: {}
+}",
+	);
+	t.expect_value(val)?;
+	//
+	Ok(())
+}
+
 #[tokio::test]
 async fn define_statement_event_when_event() -> Result<(), Error> {
 	let sql = "